Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/nodejs handling #808

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Chore/nodejs handling #808

merged 2 commits into from
Jan 2, 2025

Conversation

escapedcat
Copy link
Collaborator

@escapedcat escapedcat commented Dec 26, 2024 •
edited
Loading

  • switch from nvm to asdf
  • add node v22 to github action matrix

cstenglein
cstenglein approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@cstenglein cstenglein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm more happy with using the defaults, but asdf should work as well.

Thank you! 🙏

@cstenglein cstenglein merged commit c5d24b3 into master Jan 2, 2025
3 checks passed
@cstenglein cstenglein deleted the chore/nodejs-handling branch January 2, 2025 10:14
@escapedcat
Copy link
Collaborator Author

With "defaults" you mean "no version manager"? 0_o

@cstenglein
Copy link
Collaborator

No, nvm is officially recommended, see https://nodejs.org/en/download

@escapedcat
Copy link
Collaborator Author

Ah, got it, thanks! I switched to asdf because it supports more than just nodejs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstenglein cstenglein cstenglein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@escapedcat @cstenglein