curl: enable PACKAGECONFIG for HTTP/2 (nghttp2) on the target #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnez
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
The change looks good and justified to me, since the speedups achievable via HTTP/2 in the adaptive update case are so large.
As mentioned a comment would be nice, so that one does not have to refer to the commit message.
I am currently building a bundle based on this and will check if HTTP/2 works with it.
Since curl is used in a lot of packages this takes some time.
|
I've tested the change now and with it applied I see |
Without HTTP/2 support, streaming installation is significantly slower. Signed-off-by: Jan Luebbe <[email protected]>
hnez
approved these changes
Jul 24, 2024
|
backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without HTTP/2 support, streaming installation is significantly slower.