Refactor (#395)

raviqqe · Jul 2, 2024 · 9bfe2f0 · 9bfe2f0
1 parent a5b18c9
commit 9bfe2f0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/link_finder.go b/link_finder.go
@@ -41,11 +41,10 @@ func (f linkFinder) Find(n *html.Node, base *url.URL) map[string]error {
 		return ok
 	}) {
 
-		// https://github.com/raviqqe/muffet/issues/391
-		// preconnect and dns-prefetch hrefs are not http resources
+		// `preconnect` and `dns-prefetch` links are not HTTP resources.
 		if n.DataAtom == atom.Link {
-			rel := scrape.Attr(n, "rel")
-			if rel == "preconnect" || rel == "dns-prefetch" {
+
+			if rel := scrape.Attr(n, "rel"); rel == "preconnect" || rel == "dns-prefetch" {
 				continue
 			}
 		}

diff --git a/link_finder_test.go b/link_finder_test.go
@@ -225,9 +225,9 @@ func TestLinkFinderIgnorePreconnect(t *testing.T) {
 		html      string
 		linkCount int
 	}{
-		{`<link rel="preconnect" href="https://fonts.googleapis.com">`, 0},
-		{`<link rel="dns-prefetch" href="https://fonts.googleapis.com">`, 0},
-		{`<link rel="dns-prefetch" href="https://fonts.googleapis.com"><link href="https://fonts.googleapis.com/css2?family=Lato:ital,wght@0,300;0,400;0,700;1,400&amp;family=Source+Sans+Pro:ital,wght@0,300;0,400;0,600;1,400&amp;display=swap" rel="stylesheet">`, 1},
+		{`<link rel="preconnect" href="https://foo.com">`, 0},
+		{`<link rel="dns-prefetch" href="https://foo.com">`, 0},
+		{`<link rel="dns-prefetch" href="https://foo.com"><link href="https://bar.com/baz.css" rel="stylesheet">`, 1},
 	} {
 		n, err := html.Parse(strings.NewReader(htmlWithBody(c.html)))
 		assert.Nil(t, err)