Solution/diana calderon #11
Conversation
| function solution() { | ||
| // YOUR SOLUTION GOES HERE | ||
|
|
||
| // you get your 5 names here | ||
|
|
||
| const vars = process.argv.slice(2).length ? [...process.argv.slice(2)] : ['John', 'Diana', 'Jose', 'Stacy', 'Mary']; |
There was a problem hiding this comment.
Here I would recommend assigning the terminal arguments to a variable so it has a clear name and you don't have to repeat it
There was a problem hiding this comment.
If you are going to handle the case of comma separated arguments. I would handle it here as well. So that way your constant vars is an array of strings. This will clean up a lot of the code below. You can handle it with a nested turnery or a let variable with a if/else block underneath that will assign it
| success.push(data); | ||
| } | ||
|
|
||
| counter++; |
There was a problem hiding this comment.
I don't think you need to keep track of a count here. Would probably just push the success data like you are, then log the array
| } | ||
|
|
||
| // iterate the names array and validate them with the method | ||
| const callbackPromisify = promisify(callback) |
There was a problem hiding this comment.
I think you meant to use this somewhere?
|
|
||
| counter++; | ||
| // log the final result | ||
| if(counter === names.length){ |
There was a problem hiding this comment.
I would just log the array. It doesn't seem very valuable to add all this logic to get the output exactly like the example
| return validateNames(lastname); | ||
| }) | ||
| .then( firstnameResult => { | ||
| firstname = firstnameResult; |
There was a problem hiding this comment.
Can you return a promise here with the firstName so you don't have to assign it but instead pass it to the finally?
No description provided.