Fixed RD-15252: Missing handling of TIMESTAMPTZOID #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgaidioz
commented
Dec 23, 2024
| @@ -1805,6 +1805,7 @@ datumToPython(Datum datum, Oid type, ConversionInfo * cinfo) | |||
| return datumDecimalToPython(datum, cinfo); | |||
| case DATEOID: | |||
| return datumDateToPython(datum, cinfo); | |||
| case TIMESTAMPTZOID: | |||
There was a problem hiding this comment.
I believe Postgres stores a timestamp with time zone after having shifted it by its timezone offset. Does that mean we're getting a timestamp without timezone, but shifted?
bgaidioz
commented
Dec 26, 2024
| PyDateTime_IMPORT; | ||
| timestamp2tm(DatumGetTimestampTz(datum), &tzp, pg_tm_value, &fsec, | ||
| &tzn, session_timezone); | ||
| result = PyDateTime_FromDateAndTime(pg_tm_value->tm_year, |
There was a problem hiding this comment.
Needs to pass the timezone offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An expression like
NOW()evaluates to aTIMESTAMPTZwhich fails to be converted and is sent as a string.The patch ensures it's processed like a timestamp and the query doesn't fail.