-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing universal logger #16
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues to think about...
private val TRACE_ID = "traceId" | ||
} | ||
|
||
trait TraceIdLogging extends ContextLogging { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If one inherits the TraceIdLogging trait
, it can set the trace ID with the dedicated methods (as the name indicates), but also has access to the inner ContextLogging
methods that permit to add any random key to MDC. Just wondering if that could be a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interface and what it leads to in the log files looks convenient.
Added scala and java key-value pair logger