Merge pull request #45 from ssnm-a/exclude-union

UNIONが含まれたSQLをcountQuery生成から除外
ray-di · Aug 22, 2019 · 93e31d2 · 93e31d2
2 parents 5c5c78d + e0a087d
commit 93e31d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/Pagerfanta/ExtendedPdoAdapter.php b/src/Pagerfanta/ExtendedPdoAdapter.php
@@ -108,6 +108,9 @@ public function getLimitClause($offset, $length)
      */
     public function rewriteCountQuery($query)
     {
+        if (\is_int(\strpos(\strtolower($query), 'union'))) {
+            return '';
+        }
         if (\preg_match('/^\s*SELECT\s+\bDISTINCT\b/is', $query) || \preg_match('/\s+GROUP\s+BY\s+/is', $query)) {
             return '';
         }

diff --git a/tests/Pagerfanta/ExtendedPdoAdapterTest.php b/tests/Pagerfanta/ExtendedPdoAdapterTest.php
@@ -62,6 +62,7 @@ public function splProvider()
             ['SELECT * FROM posts', [], 'SELECT COUNT(*) FROM posts', 50],
             ['SELECT DISTINCT id FROM posts', [], '', 50],
             ['SELECT * FROM posts WHERE id > :num', ['num' => 10], 'SELECT COUNT(*) FROM posts WHERE id > :num', 40],
+            ['SELECT id FROM posts UNION SELECT id FROM posts', [], '', 50],
         ];
     }