more pr feedback

Signed-off-by: Matthew Owen <[email protected]>

python/ray/data/_internal/execution/interfaces/op_runtime_metrics.py

@@ -111,14 +111,14 @@ class RunningTaskInfo:
 
 @dataclass
 class NodeMetrics:
-    num_tasks_submitted: int = field(default=0)
-    num_tasks_running: int = field(default=0)
-    num_tasks_finished: int = field(default=0)
-    obj_store_mem_used: int = field(default=0)
-    obj_store_mem_freed: int = field(default=0)
-    obj_store_mem_spilled: int = field(default=0)
-    bytes_outputs_of_finished_tasks: int = field(default=0)
-    blocks_outputs_of_finished_tasks: int = field(default=0)
+    num_tasks_submitted: int = 0
+    num_tasks_running: int = 0
+    num_tasks_finished: int = 0
+    obj_store_mem_used: int = 0
+    obj_store_mem_freed: int = 0
+    obj_store_mem_spilled: int = 0
+    bytes_outputs_of_finished_tasks: int = 0
+    blocks_outputs_of_finished_tasks: int = 0
 
 
 class OpRuntimesMetricsMeta(type):

python/ray/data/_internal/stats.py

@@ -606,7 +606,13 @@ def _run_update_loop():
     def _aggregate_per_node_metrics(
         self, op_metrics: List[OpRuntimeMetrics]
     ) -> Optional[Mapping[str, Mapping[str, Union[int, float]]]]:
-        # Do not attempt to aggregate per node metrics if they are disabled.
+        """
+        Aggregate per-node metrics from a list of OpRuntimeMetrics objects.
+
+        If per-node metrics are disabled in the current DataContext, returns None.
+        Otherwise, it sums up all NodeMetrics fields across the provided metrics and
+        returns a nested dictionary mapping each node ID to a dict of field values.
+        """
         if not DataContext.get_current().enable_per_node_metrics:
             return None