[Core][Autoscaler] Refactor v2 Log Formatting #49350
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanaoleary
changed the title
ryanaoleary
changed the title
ryanaoleary
force-pushed
the
refactor-v2-logs
branch
2 times, most recently
from
7589e14 to
30fe22c
Compare
Signed-off-by: ryanaoleary <[email protected]>
ryanaoleary
force-pushed
the
refactor-v2-logs
branch
from
30fe22c to
d36e447
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Change v2 autoscaler logs to directly format from Cluster state. This PR also changes the v2 logs to use
instance_idrather than the IP address of each node.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.