Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Support class constructor args for filter() #50245

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

liuxsh9
Copy link
Contributor

@liuxsh9 liuxsh9 commented Feb 5, 2025

Why are these changes needed?

Get user request to support class constructor args for dataset.filter(), similar to flat_map, map, and map_batches.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@liuxsh9 liuxsh9 requested a review from a team as a code owner February 5, 2025 07:44
@jcotant1 jcotant1 added the data Ray Data-related issues label Feb 6, 2025
@richardliaw richardliaw added the go add ONLY when ready to merge, run all tests label Feb 9, 2025
@richardliaw richardliaw merged commit 499838a into ray-project:master Feb 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Ray Data-related issues go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants