Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Make memory an explicit map parameter #50269

Merged
merged 28 commits into from
Feb 6, 2025
Merged

[Data] Make memory an explicit map parameter #50269

merged 28 commits into from
Feb 6, 2025

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

Configuring per-task memory is one of the easiest ways to workaround OOMs. However, most people don't know you can do this, and the current syntax is implicit:

Before

ds.map_batches(..., ray_remote_args={"memory": ...})

After

ds.map_batches(..., memory=...)

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani requested a review from a team as a code owner February 5, 2025 22:59
@bveeramani bveeramani changed the title [Data] Make memory an explicit parameter [Data] Make memory an explicit map parameter Feb 5, 2025
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Can we add some information in the docs about how to use this parameter effectively? Like a small user guide paragraph would be great.

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani enabled auto-merge (squash) February 5, 2025 23:38
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Feb 5, 2025
@bveeramani bveeramani disabled auto-merge February 5, 2025 23:59
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani enabled auto-merge (squash) February 6, 2025 18:49
@bveeramani bveeramani merged commit aa39c04 into master Feb 6, 2025
6 checks passed
@bveeramani bveeramani deleted the memory-param branch February 6, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants