Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Enable check-json hooks in pre-commit #50366

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

win5923
Copy link
Contributor

@win5923 win5923 commented Feb 9, 2025

Why are these changes needed?

As title

Related issue number

#47991

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: win5923 <[email protected]>
@win5923 win5923 marked this pull request as draft February 9, 2025 11:48
Comment on lines +9 to +11
python/ray/data/examples/data/|
release/release_logs/|
rllib/tests/data|
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are generated files.

$ pre-commit run check-json --all-files
check json...............................................................Failed
- hook id: check-json
- exit code: 1

rllib/tests/data/pendulum/small.json: Failed to json decode (Extra data: line 2 column 1 (char 685))
rllib/tests/data/cartpole/small.json: Failed to json decode (Extra data: line 2 column 1 (char 16336))
python/ray/data/examples/data/different-extensions/data.json: Failed to json decode (Expecting value: line 1 column 1 (char 0))
python/ray/data/examples/data/iris.json: Failed to json decode (Extra data: line 2 column 1 (char 95))
rllib/tests/data/cartpole/large.json: Failed to json decode (Extra data: line 2 column 1 (char 63050))
rllib/tests/data/pendulum/large.json: Failed to json decode (Extra data: line 2 column 1 (char 102630))
python/ray/data/examples/data/image-datasets/different-extensions/data.json: Failed to json decode (Expecting value: line 1 column 1 (char 0))
rllib/tests/data/cartpole/cartpole-v1.jsonl/1_000000_000000.json: Failed to json decode (Extra data: line 2 column 1 (char 337))
rllib/tests/data/cartpole/cartpole-v1_large.jsonl/1_000000_000000.json: Failed to json decode (Extra data: line 2 column 1 (char 363))

@win5923 win5923 marked this pull request as ready for review February 9, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant