Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Redact redis password in log #50409

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

letaoj
Copy link
Contributor

@letaoj letaoj commented Feb 11, 2025

Why are these changes needed?

This change is needed to prevent redis password been logged in the standard logging. This is a secure vulnerability.

Related issue number

Closes #50266

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Feb 11, 2025
@pcmoritz pcmoritz added the go add ONLY when ready to merge, run all tests label Feb 11, 2025
Signed-off-by: Philipp Moritz <[email protected]>
@pcmoritz
Copy link
Contributor

Thanks for the contribution! I made a small fix and verified it works:

==> ray_client_server.err <==
2025-02-11 14:16:26,814	INFO server.py:900 -- Starting Ray Client server on 127.0.0.1:10001, args Namespace(host='127.0.0.1', port=10001, mode='proxy', address='127.0.0.1:6379', redis_username=None, redis_password='****', runtime_env_agent_address='http://127.0.0.1:60712')

@pcmoritz pcmoritz enabled auto-merge (squash) February 11, 2025 22:18
@letaoj
Copy link
Contributor Author

letaoj commented Feb 11, 2025

@pcmoritz ah, I saw you enabled auto merge. Thanks!

@pcmoritz pcmoritz merged commit 64a2e40 into ray-project:master Feb 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ray Core] Redis password got logged when starting the client server
3 participants