[Autoscaler][V2] Use running node instances to rate-limit upscaling #50414
+16
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR changes the v2 autoscaler scale up logic to use
IMInstance.RAY_RUNNING
(rather thanIMInstance.REQUESTED
+ nodes with anIMInstance.cloud_instance_id
) when computing the number of nodes to launch per node type. This is to maintain consistency with howupscaling_speed
is handled by the V1 autoscaler and described in the Ray docs, i.e. the factor by which to scale the number of nodes in the cluster, with a minimum of 5.Related issue number
Closes #50259
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.