Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autoscaler][V2] Use running node instances to rate-limit upscaling #50414

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ryanaoleary
Copy link
Contributor

@ryanaoleary ryanaoleary commented Feb 11, 2025

Why are these changes needed?

This PR changes the v2 autoscaler scale up logic to use IMInstance.RAY_RUNNING (rather than IMInstance.REQUESTED + nodes with an IMInstance.cloud_instance_id) when computing the number of nodes to launch per node type. This is to maintain consistency with how upscaling_speed is handled by the V1 autoscaler and described in the Ray docs, i.e. the factor by which to scale the number of nodes in the cluster, with a minimum of 5.

Related issue number

Closes #50259

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ryanaoleary ryanaoleary marked this pull request as ready for review February 11, 2025 08:36
@ryanaoleary ryanaoleary requested review from hongchaodeng and a team as code owners February 11, 2025 08:36
@edoakes edoakes requested a review from kevin85421 February 11, 2025 13:59
@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Autoscaler][V2] Autoscaler V2 does not honor 'Conservative' upscaling mode
2 participants