-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GLFW runtime platform detection #3863
Conversation
It is my impression that If there is to be an exception to that, I trust you confirmed that before all of the work you did. |
@orcmid If GLFW's developers agree to avoid functions with the same name in different platforms in a future version of the library, there will be no more need for it to be modified for raylib (related: glfw/glfw#2502 and glfw/glfw#2462). |
@M374LX I think it is a policy for raylib that externals are not to be customized and then have to be maintained here as a fork. I don't know what @raysan5 will say about this particular complicated case. Do you see an alternative approach that would overcome the difficulty for raylib without touching |
@M374LX @orcmid I try to avoid customizing external libraries for raylib but unfortunately it was also done in the past with other external libraries ( Just waiting a bit for GLFW response on the topic. The only issue I see is the need to review it again after next GLFW release, but it can take some time. |
@M374LX thanks for the improvements! |
This breaks the zig build on linux. |
Fixes #3850
In order to allow all of GLFW's source files to be combined into one, as done by
rglfw.c
, this PR modifies the bundled GLFW by renaming the functions that share the same name in different platforms. Additionally, it disables GLFW's Null platform, which is not used by raylib.It also removes the
USE_WAYLAND_DISPLAY
variable from the Makefile while addingGLFW_LINUX_ENABLE_WAYLAND
andGLFW_LINUX_ENABLE_X11
, both set toTRUE
by default.