Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove file icon button alignment while uploading #2485

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

tewarig
Copy link
Contributor

@tewarig tewarig commented Jan 17, 2025

Description

Had a discussion with @~RK. Other actions like preview and delete are center-aligned, so we should center-align the 'Remove File' action while uploading.

Prev -
Screenshot 2025-01-17 at 3 45 42 PM

Now -
Screenshot 2025-01-17 at 3 49 05 PM

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Jan 17, 2025

🦋 Changeset detected

Latest commit: b4fef91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 17, 2025

✅ PR title follows Conventional Commits specification.

Copy link

codesandbox-ci bot commented Jan 17, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b4fef91:

Sandbox Source
razorpay/blade: basic Configuration

@tewarig tewarig changed the title fix: remove file alignment while uploading fix: remove file icon alignment while uploading Jan 17, 2025
@tewarig tewarig changed the title fix: remove file icon alignment while uploading fix: remove file icon button alignment while uploading Jan 17, 2025
@rzpcibot
Copy link
Collaborator

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
FileUpload 17.833 17.839 +0.006 KB

Generated by 🚫 dangerJS against b4fef91

@tewarig tewarig merged commit 2692d5b into master Jan 23, 2025
12 of 14 checks passed
@tewarig tewarig deleted the fix/remove-file-aligmment-while-uploading branch January 23, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants