Update bonding for extra parameters #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After noting the overlap with PR 99, I went ahead and incorporated that change into this PR. |
esalberg
force-pushed
the
bond_update
branch
4 times, most recently
from
a171d66 to
ef145c6
Compare
|
The checks are failing because of: An error occurred while installing json_pure (2.0.2), and Bundler cannot I will try and figure this out, but is this a more systemic issue? |
|
Spec tests are failing due to a lack of tight controls on gem versions in the Gemfile. This was fixed in tag: 3.9.0. |
|
Rebased. |
|
Note: Needs README update. |
razorsedge
reviewed
Jul 31, 2017
| # $ethtool_opts - optional | ||
| # $zone - optional |
There was a problem hiding this comment.
Nevermind. You are just adding to the puppetdoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed macadress for bond slaves to be optional (if not provided, try to get value from facts); also added missing comment lines for previously added params.
Added explicit userctl, bootproto, onboot for bond slaves.
Added explicit userctl for static bonds (also reordered a couple params for consistency).
Updated templates; updated specs.