-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAP2! #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump Dev Branch
BenchmarkDotNet=v0.12.1, OS=ubuntu 18.04
Intel Xeon Platinum 8272CL CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores
.NET Core SDK=3.1.405
[Host] : .NET Core 3.1.11 (CoreCLR 4.700.20.56602, CoreFX 4.700.20.56604), X64 RyuJIT
DefaultJob : .NET Core 3.1.11 (CoreCLR 4.700.20.56602, CoreFX 4.700.20.56604), X64 RyuJIT
|
rbaker26
added
API
GUI
Improvements or additions to GUI
Lib/Engine
Improvements or additions to Lib/Engine
labels
Jan 20, 2021
rbaker26
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAP2 Engine, Assembler, and Library implementation with some minor GUI updates.
Description
SAP2 Updates
Pretty happy with how this came out. The whole SAP2 architecture, except dealing with IN instruction since we need to discuss more and plan on the final way of implementing this between the CLI and GUI. CLI still needs to be updated to handle the SAP2 and its architecture.
GUI
GUI updates include having the emulator picker looking more clean and zooming on hover. The Assembler section of the page now can assemble SAP1 or SAP2 based on a combo box selection and it will populate the Instruction Set combo box based on the emulator.
Motivation and Context
We wanted to implement the SAP2 and we did.
#152
How Has This Been Tested?
New tests have been added per new project and every instruction except IN has been tested.
Screenshots (if appropriate):
Types of changes
Checklist: