Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAP2! #201

Merged
merged 22 commits into from
Jan 21, 2021
Merged

SAP2! #201

merged 22 commits into from
Jan 21, 2021

Conversation

BryceCallender
Copy link
Collaborator

@BryceCallender BryceCallender commented Jan 20, 2021

SAP2 Engine, Assembler, and Library implementation with some minor GUI updates.

Description

SAP2 Updates
Pretty happy with how this came out. The whole SAP2 architecture, except dealing with IN instruction since we need to discuss more and plan on the final way of implementing this between the CLI and GUI. CLI still needs to be updated to handle the SAP2 and its architecture.

GUI
GUI updates include having the emulator picker looking more clean and zooming on hover. The Assembler section of the page now can assemble SAP1 or SAP2 based on a combo box selection and it will populate the Instruction Set combo box based on the emulator.

Motivation and Context

We wanted to implement the SAP2 and we did.

#152

How Has This Been Tested?

New tests have been added per new project and every instruction except IN has been tested.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit and integration tests to cover my changes.
  • All new and existing tests passed.
  • I updated the SamVer in the appropriate .csproj file (only for to-master-merges, ask rbaker26 for a release number).

@github-actions
Copy link

BenchmarkDotNet=v0.12.1, OS=ubuntu 18.04
Intel Xeon Platinum 8272CL CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores
.NET Core SDK=3.1.405
  [Host]     : .NET Core 3.1.11 (CoreCLR 4.700.20.56602, CoreFX 4.700.20.56604), X64 RyuJIT
  DefaultJob : .NET Core 3.1.11 (CoreCLR 4.700.20.56602, CoreFX 4.700.20.56604), X64 RyuJIT

Method Mean Error StdDev Ratio RatioSD
EngineRun_HLT 116.8 μs 0.60 μs 0.53 μs 1.00 0.00
EngineRun_LDA170 136.2 μs 0.65 μs 0.61 μs 1.17 0.01
EngineRun_FIB5 753.5 μs 14.36 μs 14.10 μs 6.44 0.13

@rbaker26 rbaker26 added API GUI Improvements or additions to GUI Lib/Engine Improvements or additions to Lib/Engine labels Jan 20, 2021
@rbaker26 rbaker26 added this to the v4.0.0-rc milestone Jan 20, 2021
@rbaker26 rbaker26 linked an issue Jan 20, 2021 that may be closed by this pull request
@rbaker26 rbaker26 merged commit 5d34584 into v4.0.0-rc Jan 21, 2021
@rbaker26 rbaker26 deleted the SAP2 branch February 8, 2021 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API GUI Improvements or additions to GUI Lib/Engine Improvements or additions to Lib/Engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAP2 Engine - Initial Work
2 participants