Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added comments to docs #35

Merged
merged 12 commits into from
Jan 6, 2023
Merged

added comments to docs #35

merged 12 commits into from
Jan 6, 2023

Conversation

SteveHenley
Copy link
Collaborator

No description provided.

@SteveHenley
Copy link
Collaborator Author

@Valentine-Mario please check my work. I am getting lost. I still need to do the following fn:

get_new_rev_address()
verify_rev_addr()
get_eth_addr_from_public_key()

Valentine-Mario
Valentine-Mario requested changes Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@Valentine-Mario Valentine-Mario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add comments about the function description

src/utils/eth_address_from_public_key.rs Outdated Show resolved Hide resolved
src/utils/pub_from_private.rs Outdated Show resolved Hide resolved
src/utils/pub_from_private.rs Outdated Show resolved Hide resolved
src/utils/eth_address_from_public_key.rs Outdated Show resolved Hide resolved
src/utils/rev_address_from_public_key.rs Outdated Show resolved Hide resolved
src/utils/rev_address_from_public_key.rs Outdated Show resolved Hide resolved
@Bill-Kunj
Copy link
Contributor

Bill-Kunj commented Dec 29, 2022 •
edited
Loading

One of the commits in this PR also closes our private-key issue #11
This enables all the unit-test stuff #8, #7, and #6

Can we open issues for the remaining questions so we can get #11 closed out and merged?

@Bill-Kunj Bill-Kunj mentioned this pull request Jan 6, 2023
Closed
@Bill-Kunj Bill-Kunj requested review from Bill-Kunj and removed request for Valentine-Mario January 6, 2023 16:25
@Bill-Kunj Bill-Kunj merged commit 0bfb22b into master Jan 6, 2023
@Bill-Kunj Bill-Kunj deleted the steve_branch branch January 6, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valentine-Mario Valentine-Mario Valentine-Mario requested changes

@Bill-Kunj Bill-Kunj Bill-Kunj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SteveHenley @Bill-Kunj @Valentine-Mario