refactor all instances of RCPCH NHS Organisations API URL #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc2007git
reviewed
Jun 13, 2024
| @@ -33,7 +33,7 @@ def retrieve_pdu_list(): | |||
| """ | |||
|
|
|||
| url = settings.RCPCH_NHS_ORGANISATIONS_API_URL | |||
| request_url = f"{url}/paediatric_diabetes_units/extended" | |||
| request_url = f"{url}/paediatric_diabetes_units/extended/" | |||
There was a problem hiding this comment.
Have entered this url (with the preceding url from example.env) into my browser and receiving a 500 error. Is the API definitely live? Or have I missed something? Should the API not respond with a JSON of the PDUs?
|
i think this has been implemented elsewhere so closing here |
|
It wasn't implemented - PR here: #397 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
Overview
RCPCH_NHS_ORGANISATIONS_API_URLwas hardcoded because of difficulties on the azure side for this API that are now fixed.This PR adds RCPCH_NHS_ORGANISATIONS_API_URL to the .env please add RCPCH_NHS_ORGANISATIONS_API_URL="https://api.rcpch.ac.uk/nhs-organisations/v1" to your local untracked .env
There are not keys for this API
Any uses across the codebase have been refactored