Users unable to enter new patients on the Platform

[SAbdin93]

Hiya,

I’ve received two separate queries from users who are unable to add new patients, encountering a message that reads: "Unique reference number (URN) already exists."

For the first query, I’ve checked, and there is no record of the patient in the system, nor has the patient been uploaded by any other user/trust. Therefore, they should be able to create a new entry...but they can't.

For the second query, the user has confirmed that the patients are newly diagnosed and would not have been added to the platform previously by them or any other trust.

Could you please look into this?

Let me know if there is anything you need from me.

Saleema

[mbarton]

Thanks @SAbdin93. From the look of the error message I would guess this has happened after we merged in support for Jersey (#1105).

I will look into this now as a priority

[mbarton]

I can reproduce in staging - I was able to add one patient but then the second failed

It was not possible to save the case: unique_reference_number: Patient with this Unique Reference Number (URN) already exists.

It seems like our uniqueness constraint does not handle URN being null

[mbarton]

I think unique_reference_number may end up as the empty string in the database rather than NULL. This is from a patient I added locally:

>>> from epilepsy12.models import *
>>> Case.objects.get(pk=6)
<Case: Bob Dylan>
>>> Case.objects.get(pk=6).nhs_number
'2900743109'
>>> Case.objects.get(pk=6).unique_reference_number
''
>>> Case.objects.get(pk=6).unique_reference_number is None
False
>>> Case.objects.get(pk=6).unique_reference_number == ''
True
>>> 

Confirmed in psql:

epilepsy12db=# select id, unique_reference_number from epilepsy12_case where id = 6;
 id | unique_reference_number 
----+-------------------------
  6 | 
(1 row)

epilepsy12db=# select id, unique_reference_number is null from epilepsy12_case where id = 6;
 id | ?column? 
----+----------
  6 | f
(1 row)

epilepsy12db=# select id, unique_reference_number = '' from epilepsy12_case where id = 6;
 id | ?column? 
----+----------
  6 | t
(1 row)

I suspect blank=True in the Case model is the culprit here. unique_reference_number is not sent in the POST when creating the patient:

[mbarton]

I was confused why I didn't get emails about this error but because it was a form validation error (I think) it wasn't logged at error