Fix adding patients outside of Jersey #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarton
added
Pending-on-LIVE
Pending-on-STAGING
Seen-on-STAGING
and removed
Pending-on-STAGING
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1190
Patients outside of Jersey have
nhs_number, notunique_reference_number. However they were ending up with their URN being the empty string (Django convention). This then broke theunique_togetherconstraint.This PR adds a cleaner to convert the empty strings to null, following the suggestion here: https://stackoverflow.com/questions/5772176/django-unique-together-and-blank-true.
We don't have the problem in reverse as we already null out the NHS number for Jersey patients in the respective cleaner.