no-location-data #1151
Merged
no-location-data #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in to max, adds tests for no location data Fixes #1150
mbarton
added
Pending-on-LIVE
Pending-on-STAGING
Seen-on-STAGING
and removed
Pending-on-STAGING
labels
|
Seen on STAGING (merged by @eatyourpeas 29 minutes and 35 seconds ago) Please check your changes! |
|
Seen on LIVE (merged by @eatyourpeas 29 minutes and 41 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1150
Overview
A recent 500 error was reported when a patient with a valid postcode was saved without creating a value in the
location_wgs84field. It is not clear how this happened, but likely occured when the postcodes api was down at some point. This meant no location data was available for the child and the dataframe that calculates distances from the lead centre threw an error.This PR filters out those children where there is no location data prior to creating the dataframe and running the distance calculations.
In addition, an incidental finding that the max distance returned was actually the min distance, so this has been fixed.
A test for this function has been added
closes #1150