kpi-3-fix #1168
Merged
kpi-3-fix #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not int, fix the impact of this on kp_6 and kpi_10 tests
nikyraja
approved these changes
Jan 15, 2025
Co-authored-by: Niky Raja <[email protected]>
|
@nikyraja included here as a co-author 🥇 |
mbarton
added
Pending-on-LIVE
Pending-on-STAGING
Seen-on-STAGING
and removed
Pending-on-STAGING
labels
|
Seen on STAGING (merged by @eatyourpeas 29 minutes and 14 seconds ago) Please check your changes! |
|
Seen on LIVE (merged by @eatyourpeas 29 minutes and 21 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There previous KPI 3 calculations did not take into account, if all criteria were met:
It also calculated age at first paediatric assessment in years without additional months, meaning children >3y would be accepted as 3 years which is a critical cut off for this measure.
This has been changed to calculate an age in decimal years instead.
To meet these items the tests for KPI 3 have all been rewritten and currently are all passing.
@nikyraja
closes #1161