Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vite function #435

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Vite function #435

wants to merge 2 commits into from

Conversation

adrum
Copy link

@adrum adrum commented Jan 14, 2024

This adds the ability to use the Laravel Vite helper

This adds the ability to use the Laravel Vite helper
@barryvdh
Copy link
Collaborator

Should we add this to the config, perhaps default commented out?

@adrum
Copy link
Author

adrum commented Jan 16, 2024

@barryvdh Definitely one of those! Is there any significant overhead with turning it on by default? Maybe we can leave it off to be on the safe side.

Let ke know if you have a preference.

@adrum
Copy link
Author

adrum commented Jan 20, 2024

@barryvdh Added it in there commented out.

Copy link

@mochaaP mochaaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, useful for our migration to Vite

mochaaP added a commit to bs-community/blessing-skin-server that referenced this pull request Feb 23, 2024
twig + vite integration done
needs rcrowe/TwigBridge#435
hmr: to be tested
@mochaaP
Copy link

mochaaP commented Apr 13, 2024

@barryvdh do you have time to take a look at this? thanks!

@n3storm
Copy link

n3storm commented May 4, 2024

I would like to see this too

@adrum
Copy link
Author

adrum commented Nov 16, 2024

@barryvdh Anything else needed from me on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants