-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CEL0 algorithm #51
base: main
Are you sure you want to change the base?
Conversation
Yazhou-Z
commented
Mar 2, 2023
- Implement the CELO method to the sparsecoding.inference
- Add a test for the CELO method.
- Add a jupyter notebook that demonstrates the method working on bars example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Yazhou!
Awesome job submitting your method and supporting files to the repo! I've made a few comments for correction to address.
The main thing to fix is the update method for CEL0. The update rule is similar to LCA, but it's not quite the same. I've detailed the difference in the inference.py file notes.
I don't know if this is related, but when I run the inference method in the bars notebook example, sometimes coefficients are right, but other times the baseline deviates significantly from zero. I suspect this will be fixed by fixing the CEL0 update rule. I've included an example of the problem below.