Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDK-54420] added annotation APIs to Dobby #349

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

goruklu
Copy link
Contributor

@goruklu goruklu commented Nov 20, 2024

Description

Adds "annotate()" and "removeAnnotation()" APIs to Dobby. With this method, key/value pairs can be set for containers at runtime.

Test Procedure

vagrant@dobby-vagrant-focal-arm64:~/srcDobby/build$ DobbyTool annotate sleep12 key1 value1
annotate successful for container 'sleep12'
vagrant@dobby-vagrant-focal-arm64:~/srcDobby/build$ DobbyTool annotate sleep12 key2 value2
annotate successful for container 'sleep12'
vagrant@dobby-vagrant-focal-arm64:~/srcDobby/build$ DobbyTool annotate sleep12 key3 value3
annotate successful for container 'sleep12'
vagrant@dobby-vagrant-focal-arm64:~/srcDobby/build$ DobbyTool annotate sleep12 key2 value5
annotate successful for container 'sleep12'
vagrant@dobby-vagrant-focal-arm64:~/srcDobby/build$ DobbyTool info sleep12
{
 "annotations" :
 {
  "key1" : "value1",
  "key2" : "value5",
  "key3" : "value3"
 },
 "id" : "sleep12",
 "state" : "running",
 "timestamp" : 1319810849810469
}
vagrant@dobby-vagrant-focal-arm64:~/srcDobby/build$ DobbyTool remove-annotation sleep12 key5
removed key5 key from container 'sleep12' annotations
vagrant@dobby-vagrant-focal-arm64:~/srcDobby/build$ DobbyTool info sleep12
{
 "annotations" :
 {
  "key1" : "value1",
  "key2" : "value5",
  "key3" : "value3"
 },
 "id" : "sleep12",
 "state" : "running",
 "timestamp" : 1319841586979048
}
vagrant@dobby-vagrant-focal-arm64:~/srcDobby/build$ DobbyTool remove-annotation sleep12 key2
removed key2 key from container 'sleep12' annotations
vagrant@dobby-vagrant-focal-arm64:~/srcDobby/build$ DobbyTool info sleep12
{
 "annotations" :
 {
  "key1" : "value1",
  "key3" : "value3"
 },
 "id" : "sleep12",
 "state" : "running",
 "timestamp" : 1319852633313708
}

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (doesn't fit into the above categories - e.g. documentation updates)

Requires Bitbake Recipe changes?

  • The base Bitbake recipe (meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updating SRC_REV)

Signed-off-by: Gurdal Oruklu <[email protected]>
@goruklu goruklu added the enhancement New feature or request label Nov 20, 2024
Signed-off-by: Gurdal Oruklu <[email protected]>
@goruklu goruklu requested a review from ks734 November 20, 2024 19:29
@goruklu goruklu changed the title [RDK-54420] added annotate() API method to Dobby [RDK-54420] added annotation APIs to Dobby Nov 20, 2024
@goruklu goruklu self-assigned this Nov 20, 2024
Copy link
Contributor

@ks734 ks734 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goruklu goruklu requested a review from bgray-sky November 21, 2024 15:15
@goruklu goruklu merged commit 25656ee into rdkcentral:master Nov 22, 2024
20 of 21 checks passed
@goruklu goruklu deleted the RDK-54420-add-annotate branch November 22, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDK-54420 Add annotate() method to Dobby API
3 participants