fix: Replace pointerH and pointerW with pointerHeight and pointerWidth #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumyaloka
requested review from
erautenberg,
joshhowenstine,
anthony9187,
ImCoolNowRight,
THoj13,
arwehrman,
jazzyw and
slhay28
as code owners
|
Test Execution Passed. |
soumyaloka
changed the title
|
Should there be an Sorry missed your comment, so those texture classes don't use the withThemeStyles mixin so they don't have the alias support. |
ImCoolNowRight
approved these changes
Oct 25, 2023
arwehrman
approved these changes
Oct 25, 2023
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Oct 25, 2023
# [@lightningjs/ui-components-v2.14.4](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.14.3...@lightningjs/ui-components-v2.14.4) (2023-10-25) ### Bug Fixes * Replace pointerH and pointerW with pointerHeight and pointerWidth ([#391](#391)) ([8711fbf](8711fbf))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.14.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the problem by replacing the old names inside the Bubble texture, resolving the tooltip size and missing bubble issue
References
LUI-1156
Testing
Verify if Tooltip UI looks as expected.