fix(Surface): update backgroundColor to use interactive tokens #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erautenberg
requested review from
joshhowenstine,
anthony9187,
ImCoolNowRight,
THoj13,
arwehrman,
jazzyw,
soumyaloka and
slhay28
as code owners
|
Test Execution Passed. |
erautenberg
force-pushed
the
fix/Surface-styles
branch
from
5b0aaa6 to
669839b
Compare
ImCoolNowRight
approved these changes
Oct 30, 2023
|
Test Execution Passed. |
soumyaloka
approved these changes
Oct 30, 2023
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Nov 1, 2023
# [@lightningjs/ui-components-v2.15.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.14.4...@lightningjs/ui-components-v2.15.0) (2023-11-01) ### Bug Fixes * **Badge:** update contentSpacing and paddingX ([#393](#393)) ([3c5e13a](3c5e13a)) * **Surface:** update backgroundColor to use interactive tokens ([#395](#395)) ([d3b81ef](d3b81ef)) ### Features * **Base:** update theme to include new interactive tokens and footnote1 typography ([#392](#392)) ([63cff01](63cff01)) * **Button:** update default style mappings and calculate height dynamically ([#394](#394)) ([77ccf44](77ccf44))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is dependent on #392 to update to the new interactive tokens.
References
Testing
Confirm that Surface component looks just about the same (bite be a slightly different white color).
Automation
Checklist