Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TextBox): ensure styles (like textStyles) are passed from TextBox to InlineContent #422

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix(TextBox): ensure styles (like textStyles) are passed from TextBox to InlineContent #422

merged 1 commit into from
Nov 28, 2023

Conversation

erautenberg
Copy link
Contributor

Description

Currently, any custom styles set on TextBox as a whole as not getting passed down to the InlineContent component is the TextBox needs to use it. This means that when using TextBox with InlineContent in various Metadata components, the styles are incorrect.y

References

Testing

In TextBox.stories.js, add custom styles to the WithInlineContentString story and observe these now getting applied.

          style: {
            textStyle: {
              textColor: getHexColor('00ff00')
            }
          }

Automation

Checklist

  • all commented code has been removed
  • any new console issues have been resolved
  • code linter and formatter has been run
  • test coverage meets repo requirements
  • PR name matches the expected semantic-commit syntax

@erautenberg erautenberg force-pushed the fix/TextBox-pass-styles branch from 416ba5f to a2e3e24 Compare November 27, 2023 20:59
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

1 similar comment
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@erautenberg erautenberg changed the title fix(TextBox): ensure styles (like textStyles) as passed from TextBox to InlineContent fix(TextBox): ensure styles (like textStyles) are passed from TextBox to InlineContent Nov 28, 2023
@erautenberg erautenberg merged commit 29deae6 into develop Nov 28, 2023
8 checks passed
@erautenberg erautenberg deleted the fix/TextBox-pass-styles branch November 28, 2023 16:18
svc-lightning-ui-components pushed a commit that referenced this pull request Nov 30, 2023
@semantic-release-bot
chore(release): 2.18.0 [skip ci]
99e625d 
# [@lightningjs/ui-components-v2.18.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.17.0...@lightningjs/ui-components-v2.18.0) (2023-11-30)

### Bug Fixes

* **InlineContent:** check if item is text or text object before adding margin and adjust whitespace parsing ([#424](#424)) ([a8ad18f](a8ad18f))
* **TextBox:** ensure styles (like textStyles) as passed from TextBox to InlineContent when appropriate ([#422](#422)) ([29deae6](29deae6))
* updates to fix merge order issue ([#413](#413)) ([4ea31f1](4ea31f1))

### Features

* **Keyboard:** calculate key size based on base key width ([#421](#421)) ([1d28357](1d28357))
@svc-lightning-ui-components
Copy link
Collaborator

🎉 This PR is included in version @lightningjs/ui-components-v2.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImCoolNowRight ImCoolNowRight ImCoolNowRight approved these changes

@THoj13 THoj13 THoj13 approved these changes

@joshhowenstine joshhowenstine Awaiting requested review from joshhowenstine joshhowenstine is a code owner

@anthony9187 anthony9187 Awaiting requested review from anthony9187 anthony9187 is a code owner

@arwehrman arwehrman Awaiting requested review from arwehrman

@jazzyw jazzyw Awaiting requested review from jazzyw

@soumyaloka soumyaloka Awaiting requested review from soumyaloka soumyaloka is a code owner

@slhay28 slhay28 Awaiting requested review from slhay28

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erautenberg @svc-lightning-ui-components @ImCoolNowRight @THoj13