fix(NavigationManager): allow itemPosX and itemPosY to animate #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erautenberg
requested review from
joshhowenstine,
anthony9187,
ImCoolNowRight,
THoj13,
arwehrman,
jazzyw,
soumyaloka and
slhay28
as code owners
|
Test Execution Passed. |
…ems element and adjust on the update lifecycle
erautenberg
force-pushed
the
fix/NavigationManager-animate-itemPos
branch
from
5e39c16 to
4b4bc01
Compare
|
Test Execution Passed. |
|
|
|
Test Execution Passed. |
1 similar comment
|
Test Execution Passed. |
|
Test Execution Passed. |
|
Test Execution Passed. |
1 similar comment
|
Test Execution Passed. |
ImCoolNowRight
force-pushed
the
fix/NavigationManager-animate-itemPos
branch
from
e00b890 to
7ac02e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
itemPosXanditemPosYproperties of FocusManager/NavigationManager/Column/Row instantly updated the x and y values of the Items element. This prevents animating the Items element and making a smoother transition for something like the Title and Items in the TitleRow if the titleMarginBottom changes on focus/unfocus. The scrolling logic will update the Items container's x or y based on the scroll direction, so this just updates the opposite direction for something like the title.References
Testing
Check out the new "Shifting Item Pos" story for the Column container and confirm that the titles are shifting as expected while the scrolling logic is also still behaving as expected.
Automation
Checklist