-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EasyConnect Seperation of Concerns Refactor #204
EasyConnect Seperation of Concerns Refactor #204
Conversation
Signed-off-by: Ben Carlson <[email protected]>
Signed-off-by: Ben Carlson <[email protected]>
Signed-off-by: Ben Carlson <[email protected]>
Signed-off-by: Ben Carlson <[email protected]>
7450d20
to
5e57ad2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stylistically I'd like to see override
used in subclasses where applicable, just makes reasoning about the code easier for instance if you're reading a subclass header, immediately obvious that a given function extends some other base class. Also, regarding send_action_frame
as a param for ec_manager
, would that be bound to send_frame
, or some new entry into em_agent
which sends action frames via the bus to onewifi
? Other than this comment and the other 2 left, LGTM.
Signed-off-by: Ben Carlson <[email protected]>
I added the Regarding the |
ec_manager