Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xml/yml config formats #10

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

gfreeau
Copy link

@gfreeau gfreeau commented May 18, 2014

Discussed in #9

@gfreeau
Copy link
Author

gfreeau commented May 18, 2014

When this is merged, the dms filter bundle will need to have support added as well. I plan to do this as I am currently working on a project that needs validation+filtering.

I noticed that a lot of the ideas from this bundle are based on the validator component, there is an opportunity to some re-use here between the validator+filter and symfony really needs a default filter component.

@rdohms
Copy link
Owner

rdohms commented May 20, 2014

Awesome, thanks.

I'm reviewing the code and trying to think of a better structure for the Loader Namespace its quite full now, I'll see what i can come up with.

I know there are similarities with Validator, it was based on it, i need to see if i can make use of something better now, back then there wasn't much available. Maybe a better package.

I'm in a pinch but i'll try to get a closer look into this

@gfreeau
Copy link
Author

gfreeau commented May 20, 2014

Yes there is a lot in that namespace now, most of it is from the validator component which is for loading multiple xml/yml files (loaderchain), perhaps that is what could be moved elsewhere.

I want to use the yml option in dms filter bundle, so this needs to be resolved before support can be added to that bundle.

See here for an example of a 3rd party metadata library: https://github.com/schmittjoh/metadata but this makes more dependencies.

@gfreeau
Copy link
Author

gfreeau commented Jun 13, 2014

What is the status of this?

@rdohms
Copy link
Owner

rdohms commented Jun 19, 2014

@gfreeau i'm sorry i have been aught up but i'll get to this soon.

@dzubchik
Copy link

@rdohms, ping! What a status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants