-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-171 #1
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference is to make this repo entirely archival and move all of the logic for it into reach-lang
; in particular, so the DRAFT variable in VERSION
stays in sync and we can just have one place to look for the release process
I kept like this because we agreed with Dan on the daily meeting that this repo would still exist to track the file changes for the stdlib since it is not fully traceable on reach-lang, should I still move it ? The version is being controlled fully through the VERSION file on the reach-lang repository. The package.json file on this repository is extracted from the reach-sh/stdlib docker image which is updated through mo using the environment var setup on the VERSION file. Line 25 in 9e85632
js-reach-stdlib/sbin/refresh.sh Line 23 in 9e85632
|
I agree with Dan that the repo should still exist, just to track the changes. My point is that it should contain only the stdlib source that was released and nothing else (i.e. the scripts are somewhere else). Also, FWIW, I recently learned about the Docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to do anything to do this (it just deletes things) but I won't approve it so we don't accidentally merge it, so we merge it AFTER we do the thing in the other repo
@DanBurton The most important part of this is just deleting the |
No description provided.