Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-171 #1

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

CORE-171 #1

wants to merge 13 commits into from

Conversation

vinmazzi
Copy link

@vinmazzi vinmazzi commented Nov 4, 2021

No description provided.

Copy link
Contributor

@jeapostrophe jeapostrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference is to make this repo entirely archival and move all of the logic for it into reach-lang; in particular, so the DRAFT variable in VERSION stays in sync and we can just have one place to look for the release process

@vinmazzi
Copy link
Author

vinmazzi commented Nov 5, 2021

I kept like this because we agreed with Dan on the daily meeting that this repo would still exist to track the file changes for the stdlib since it is not fully traceable on reach-lang, should I still move it ?

The version is being controlled fully through the VERSION file on the reach-lang repository. The package.json file on this repository is extracted from the reach-sh/stdlib docker image which is updated through mo using the environment var setup on the VERSION file.
Refs:

https://github.com/reach-sh/reach-lang/blob/b07262393d001f20616161eb42060044b31e981c/.circleci/config.pre.yml#L98

sbin/refresh.sh

-c 'cp /stdlib/*.mjs /stdlib/package.json /cwd/ && cp -r /stdlib/dist /cwd/dist && cp /stdlib/dist/types/* /cwd/'

@jeapostrophe
Copy link
Contributor

I agree with Dan that the repo should still exist, just to track the changes. My point is that it should contain only the stdlib source that was released and nothing else (i.e. the scripts are somewhere else).

Also, FWIW, I recently learned about the Docker -o feature and I think it might be an easier way to do this copy. We could make a Dockerfile that builds off reachsh/stdlib and then has FROM scratch that copies the appropriate files. Might be cleaner and wouldn't need to be a machine type

Copy link
Contributor

@jeapostrophe jeapostrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to do anything to do this (it just deletes things) but I won't approve it so we don't accidentally merge it, so we merge it AFTER we do the thing in the other repo

@jeapostrophe
Copy link
Contributor

@DanBurton The most important part of this is just deleting the sbin which has been moved to the main repo. I want you to merge this and adjust your workflow to use those scripts (until we do the automated thing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants