This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
. #3
Open
. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeapostrophe
commented
Nov 2, 2021
jeapostrophe
commented
Nov 2, 2021
jeapostrophe
commented
Nov 2, 2021
jeapostrophe
commented
Nov 2, 2021
tools/generator.js
Outdated
| return `Error writing ${cfgPath}`; | ||
| } | ||
| // Read config.json. | ||
| configJson = await fs.readJson(cfgPath); |
There was a problem hiding this comment.
Why do you read this after you just wrote it up on line 287 and then you write it again later? Why not just keep it in memory?
There was a problem hiding this comment.
Yes, you are right. I should keep it in memory. One of the plugins (copyFmToConfig) needs to update configJson (overwriting default values with frontmatter as needed) so, at the time, I wrote configJson to a file so that the plugin could read it, update it, and write it again. It might be better to just pass the configJson object to the plugin. This particular plugin still uses readJsonSync instead of async(), too. Would you be interested in making these changes as part of the PR? The plugins are in the tools/plugins folder. Thx.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.