Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add JWP lib #1266

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Conversation

Jmilham21
Copy link
Contributor

📝 Why & how

This PR adds the following library to the directory:

This PR marks the following library (owned by @chaimPaneth) as unmaintained as the above library is the successor:

✅ Checklist

  • Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json
  • Documented in this PR how to use the feature or replicate the bug.
  • Documented in this PR how you fixed or created the feature.

@Simek
Copy link
Member

Simek commented Sep 10, 2024

Hey @Jmilham21, can you move the new entry to the end of JSON file? We use the order in that file for "Recently Added" sort option - https://github.com/react-native-community/directory?tab=readme-ov-file#how-do-i-add-a-library

@Jmilham21
Copy link
Contributor Author

Hey @Simek, I've moved it to the end and merged the changes since my initial push.

Copy link
Member

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM! 🚀

@Simek Simek merged commit 7f1763c into react-native-community:main Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants