Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add @d11/react-native-fast-image #1301

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

shubh73
Copy link
Contributor

@shubh73 shubh73 commented Oct 2, 2024

πŸ“ Why & how

This PR adds the following library to the directory:

βœ… Checklist

  • Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json
  • Documented in this PR how to use the feature or replicate the bug.
  • Documented in this PR how you fixed or created the feature.

},
{
"githubUrl": "https://github.com/dream-sports-labs/react-native-fast-image",
"examples": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @shubh73, thank you for adding new entry to the directory! πŸ‘

Sorry for the unexpected CI failure, the initial commit you have made was correct. After adding back npmPkg the CI check should pass:

Suggested change
"examples": [
"npmPkg": "@d11/react-native-fast-image",
"examples": [

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the prompt response and for sorting the CI hiccup :)

@Simek Simek merged commit d2b3e9f into react-native-community:main Oct 3, 2024
2 checks passed
@shubh73 shubh73 deleted the chore/add-libs branch October 4, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants