Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added react-native-buffer and updated react-native-quick-base64 #1489

Merged
merged 3 commits into from
Jan 28, 2025
Merged

added react-native-buffer and updated react-native-quick-base64 #1489

merged 3 commits into from
Jan 28, 2025

Conversation

gabimoncha
Copy link
Contributor

📝 Why & how

✅ Checklist

  • Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json
  • Documented in this PR how to use the feature or replicate the bug.
  • Documented in this PR how you fixed or created the feature.

@gabimoncha
Copy link
Contributor Author

hi @Simek. I've noticed react-native-quick-base64 didn't pass the new arch test, and also added @craftzdog/react-native-buffer

Simek
Simek reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and an addition! 👍 Left one suggestion below, otherwise LGTM!

gabimoncha and others added 2 commits January 28, 2025 19:24
@gabimoncha @Simek
Update react-native-libraries.json
574964b 
Co-authored-by: Bartosz Kaszubowski <[email protected]>
@gabimoncha @Simek
Update react-native-libraries.json
63413df 
Co-authored-by: Bartosz Kaszubowski <[email protected]>
@gabimoncha
Copy link
Contributor Author

Thanks for the update and an addition! 👍 Left one suggestion below, otherwise LGTM!

thanks. updated the suggestions

Simek
Simek approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update! 👌

@Simek Simek merged commit 97dd9f4 into react-native-community:main Jan 28, 2025
2 checks passed
@gabimoncha gabimoncha deleted the gabimoncha/react-native-buffer branch February 9, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simek Simek Simek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabimoncha @Simek