Skip to content

Commit

Permalink
Merge pull request #16 from GreatQin1/sig
Browse files Browse the repository at this point in the history
fix: 修复modal关闭后视频声音还在播放问题
  • Loading branch information
GreatQin1 authored May 31, 2024
2 parents 3788125 + 414d2ad commit 33f1ece
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 2 deletions.
Binary file modified harmony/rn_video.har
Binary file not shown.
2 changes: 1 addition & 1 deletion harmony/rn_video/oh-package.json5
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"name": "@react-native-oh-tpl/react-native-video",
"description": "main cpai architecture",
"main": "index.ets",
"version": "5.2.1-0.2.3",
"version": "5.2.1-0.2.4",
"dependencies": {
"@rnoh/react-native-openharmony": "file:../react_native_openharmony"
}
Expand Down
5 changes: 5 additions & 0 deletions harmony/rn_video/src/main/ets/RNCVideo.ets
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,11 @@ export struct RNCVideo {
.align(Alignment.Center)
.height(this.viewHeight)
.width(this.viewWidth)
.onDisAppear(() => {
this.unregisterDescriptorChangesListener?.()
this.cleanupCommandCallback?.()
this.playVideoModel.release();
})
}
}
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@react-native-oh-tpl/react-native-video",
"version": "5.2.1-0.2.3",
"version": "5.2.1-0.2.4",
"description": "A <Video /> element for react-native",
"harmony": {
"alias": "react-native-video"
Expand Down

0 comments on commit 33f1ece

Please sign in to comment.