Add accessibilityLabel support #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YajurG
changed the title
Naturalclar
merged commit 0e6a959
into
react-native-progress-view:master
5 of 6 checks passed
|
@Naturalclar is it possible for this to be included in a release? Looking at the latest package 1.4.2, this change is not included and is a blocker for React Native Windows accessibility compliance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds accessibilityLabel support to ProgressView.
Currently, ProgressView doesn't appear to support accessibilityLabel, and the UIA Name property is always null on ProgressView components. This is an accessibility compliance issue for Windows apps, and is blocking the React Native Windows team on this issue: microsoft/react-native-gallery#368
Screenshots to show changes:
Before:
After:
