Example project fixes #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…visioning and downgraded to SDK 9 deployment target / JS: moved the PushNotificationIOS.requestPermissions call after the event registrations to avoid problems
|
Real device problem could be fixed with this solution ive also created a PR for |
Naturalclar
reviewed
May 1, 2020
| TestTargetID = 13B07F861A680F5B00A75B9A; | ||
| }; | ||
| 13B07F861A680F5B00A75B9A = { | ||
| DevelopmentTeam = UL428N5782; |
There was a problem hiding this comment.
Could we remove the DevelopmentTeam option so anyone can use the example project? 😃
There was a problem hiding this comment.
Well i though you always need to use a Development Team?
There was a problem hiding this comment.
indeed, development team is required to run the example with a real device. however, other people won't be able to use your development team id
There was a problem hiding this comment.
Odd, Xcode always forces me to select one?...But this should matter know... the developer has to adjust the xcode-project anyway :)
Naturalclar
reviewed
May 1, 2020
Naturalclar
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've just updated and configured the example project to meet the set up requirements of this library.
Compatibility
Note
Besides everything is set upped as it should be it still doesnt work on iOS 13.1.3 with my real iPhone 7 device. Fixed by #97