Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

Initial nav state is always asynchronous (for Linking.getInitialUrl) #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Minishlink
Copy link

@ericvicenti
Copy link
Contributor

I like this change, and it seems well implemented. In most cases I think things will behave the same.

But it may break things for people who expect the previous behavior of initializing the navigation state and doing another action for the URL. So I am cautious about moving forward.

cc @brentvatne, should we defer stuff like this to v4? This nuance is undocumented, so we might get away with a v3 release.

Copy link
Contributor

@ericvicenti ericvicenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but I'll leave it to @brentvatne to decide release strategy

@Minishlink
Copy link
Author

Thanks @ericvicenti

@brentvatne
Copy link
Member

@Minishlink - could you possibly write up some documentation explaining this behavior? once that's ready we can decide whether we can land it in v3 as-is, put it behind a feature flag, or defer until v4

@alexpyoung
Copy link

Hey all, looks like this fixes some behavior I'm seeing. Any idea when this might be released? Thanks

@AfrazHussain
Copy link

Any idea when this will be released? Thank you for this PR.

@iujisato
Copy link

iujisato commented Dec 4, 2019

Also waiting for this PR to fix the issue described on react-navigation/react-navigation#5844

@dccabao
Copy link

dccabao commented Dec 9, 2019

Has this issue been fixed already? Should I just update react navigation? Thanks!

@Epiczzor
Copy link

Hey, is this fixed yet ?

@t49tran
Copy link

t49tran commented Feb 17, 2020

Can this PR be updated to resolve the conflict and merge ?

@Minishlink
Copy link
Author

Unless there is a core contributor who wants to merge this, I probably won't update it until I upgrade one of my projects to RNav 5 (two to four weeks), feel free to do another one :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants