Skip to content
This repository has been archived by the owner on Feb 25, 2020. It is now read-only.

Disable bottom hit slop of iOS back button #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Manduro
Copy link

@Manduro Manduro commented Jul 25, 2019

This fixes a bug where the hit area of the back button overlaps a few pixels of content below the header, making it impossible to interact with that content.

This fixes a bug where the hit area of the back button overlaps a few pixels of content below the header, making it impossible to interact with that content.
@enagorny
Copy link
Contributor

enagorny commented Aug 2, 2019

Does it work fine on Android? As from the code I see it's bottom: 8,

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share a screenshot/gif showing the issue? We're not setting any hitSlop for iOS where this PR is adding extra hitSlop are, so I'm not understanding how it avoids extra area being overlapped

@Manduro
Copy link
Author

Manduro commented Oct 16, 2019

On Android it works fine, the hit slop does not go outside of the header bar.

This shows the issue on iOS:
back-button

This PR is not adding extra hitSlop. There is a default hitSlop for iOS here: https://github.com/react-navigation/stack/blob/master/src/views/TouchableItem.tsx#L64
I merely took the default and set the bottom to zero.

@satya164
Copy link
Member

Thanks for the clarification. Can we remove the extra hitSlop from TouchableItem instead? I think it's not needed and it's a bit confusing to have it by default.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants