feat: added label overrides on AccordionFormList #440
Conversation
Signed-off-by: Haris Spahija <[email protected]>
HarisSpahijaPon
force-pushed
the
feat-harisspahijapon-add-overrides-accordionformlist
branch
from
a3a79c4
to
36bfdd6
Compare
|
🚀 Preview deployed Built with commit a3a79c4 https://deploy-preview-440--stoic-hodgkin-c0179e.netlify.com |
|
🚀 Preview deployed Built with commit 86137e9 https://deploy-preview-440--stoic-hodgkin-c0179e.netlify.com |
| }; | ||
|
|
||
| static defaultProps = { | ||
| addNewItemButtonText: "Add an item", | ||
| deleteItemButtonText: "Delete this item", | ||
| entryFormSubmitButtonText: "Add item", | ||
| cancelButtonText: "Cancel", | ||
| saveButtonText: "Save", |
There was a problem hiding this comment.
Should be "Save Changes" to match what was there
|
@HarisSpahijaPon Your latest commit is missing DCO. You will need to sign off and force push as in the DCO check instructions: https://github.com/reactioncommerce/reaction-component-library/pull/440/checks?check_run_id=301065959 |
Signed-off-by: Haris Spahija <[email protected]>
HarisSpahijaPon
force-pushed
the
feat-harisspahijapon-add-overrides-accordionformlist
branch
from
0a39401
to
86137e9
Compare
|
DCO should be fixed now @aldeed |
|
@HarisSpahijaPon sorry for the extra work, but if you can merge latest |
|
🎉 This PR is included in version 0.68.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Part of: #409
Impact: minor
Type: feature
Component
AccordionFormList now has overrides when i18next will be implemented (see #409)
Breaking changes
No breaking chances, all added fields are optional
Testing
cancelButtonTextorsaveButtonTextto<AccordionFormList />"test"to either cancelButtonText or saveButtonTextcancelButtonTextorsaveButtonTextis not added, it should default to the values given in default props