feat: added text overrides on CartItem #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haris Spahija <[email protected]>
Signed-off-by: Haris Spahija <[email protected]>
HarisSpahijaPon
force-pushed
the
feat-harisspahijapon-add-overrides-cartitem
branch
from
248e10a
to
7889739
Compare
|
🚀 Preview deployed Built with commit 2d74021 https://deploy-preview-449--stoic-hodgkin-c0179e.netlify.com |
|
🚀 Preview deployed Built with commit fab85cb https://deploy-preview-449--stoic-hodgkin-c0179e.netlify.com |
aldeed
requested changes
Nov 26, 2019
Signed-off-by: Haris Spahija <[email protected]>
aldeed
requested changes
Dec 4, 2019
Signed-off-by: Haris Spahija <[email protected]>
HarisSpahijaPon
force-pushed
the
feat-harisspahijapon-add-overrides-cartitem
branch
from
a5c24e6
to
fab85cb
Compare
aldeed
approved these changes
Dec 9, 2019
|
🎉 This PR is included in version 0.69.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #409
Impact: minor
Type: feature
Component
CartItem now has overrides when i18next will be implemented (see #409)
Breaking changes
No breaking chances, all added fields are optional
Testing
Add a new prop
messageTextortotalTextto<CartItem />Add the value "test" to either
messageTextortotalTextButton or title should display "test" when test is given as a value to the prop. When the prop
messageTextortotalTextis not added, it should default to the values given in default props