feat: added text overrides on CartItemDetail #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarisSpahijaPon
changed the title
Signed-off-by: Haris Spahija <[email protected]>
HarisSpahijaPon
force-pushed
the
feat-harisspahijapon-add-overrides-cartitemdetail
branch
from
6da0576 to
1222834
Compare
HarisSpahijaPon
commented
Nov 26, 2019
| /** | ||
| * Product title of chosen item. | ||
| */ | ||
| title: PropTypes.string | ||
| }; | ||
|
|
||
| static defaultProps: { |
There was a problem hiding this comment.
has to be "=" instead of :
aldeed
requested changes
Nov 26, 2019
Signed-off-by: Haris Spahija <[email protected]>
…ithub.com:PonDigitalSolutions/reaction-component-library into feat-harisspahijapon-add-overrides-cartitemdetail
Signed-off-by: Haris Spahija <[email protected]>
|
🚀 Preview deployed Built with commit 02017c5 https://deploy-preview-450--stoic-hodgkin-c0179e.netlify.com |
|
done |
aldeed
approved these changes
Dec 4, 2019
|
🎉 This PR is included in version 0.69.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #409
Impact: minor
Type: feature
Component
CartItemDetail now has overrides when i18next will be implemented (see #409)
Breaking changes
No breaking chances, all added fields are optional
Testing
quantityTextto<CartItemDetail />"test"toquantityTextquantityTextis not added, it should default to the values given in default props