Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added text override on CheckoutActionComplete #452

Conversation

HarisSpahijaPon
Copy link
Contributor

Signed-off-by: Haris Spahija [email protected]

Part of: #409
Impact: minor
Type: feature

Component

CheckoutActionComplete now has overrides when i18next will be implemented (see #409)

Breaking changes

No breaking chances, all added fields are optional

Testing

  1. Add a new prop changeButtonText to <CheckoutActionComplete />
  2. Add the value "test" to changeButtonText
  3. Button should display "test" when test is given as a value to the prop. When the prop changeButtonText is not added, it should default to the values given in default props

@rc-publisher
Copy link
Collaborator

🚀 Preview deployed

Built with commit 65e9a4b

https://deploy-preview-452--stoic-hodgkin-c0179e.netlify.com

@spencern spencern merged commit 28793b4 into reactioncommerce:master Nov 26, 2019
@rc-publisher
Copy link
Collaborator

🎉 This PR is included in version 0.68.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rc-publisher rc-publisher added the released Applied automatically by semantic-release label Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Applied automatically by semantic-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants