Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added text overrides on CheckoutActions #453

Merged
merged 4 commits into from
Dec 9, 2019
Merged

feat: added text overrides on CheckoutActions #453

merged 4 commits into from
Dec 9, 2019

Conversation

HarisSpahijaPon
Copy link
Contributor

Part of: #409
Impact: minor
Type: feature

Component

CheckoutActions now has overrides when i18next will be implemented (see #409)

Breaking changes

No breaking chances, all added fields are optional

Testing

  1. Add a new prop cancelButtonText to <CheckoutActions />
  2. Add the value "test" to cancelButtonText
  3. Button should display "test" when test is given as a value to the prop. When the prop cancelButtonText is not added, it should default to the values given in default props

Added props:

cancelButtonText: PropTypes.string,
isNotSavingButtonText: PropTypes.string,
isSavingButtonText: PropTypes.string,
saveButtonText: PropTypes.string,

@HarisSpahijaPon HarisSpahijaPon force-pushed the feat-harisspahijapon-add-overrides-checkoutactions branch from 66335eb to 3ca2ba2 Compare November 21, 2019 10:37
@HarisSpahijaPon HarisSpahijaPon changed the title Feat harisspahijapon add overrides checkoutactions Feat harisspahijapon add overrides CheckoutActions Nov 21, 2019
@HarisSpahijaPon HarisSpahijaPon changed the title Feat harisspahijapon add overrides CheckoutActions feat: added text overrides on CheckoutActions Nov 21, 2019
@HarisSpahijaPon
fix: added missing comma
7e45ee8 
Signed-off-by: Haris Spahija <[email protected]>
@HarisSpahijaPon HarisSpahijaPon force-pushed the feat-harisspahijapon-add-overrides-checkoutactions branch from 08bd12e to 7e45ee8 Compare November 21, 2019 10:53
@rc-publisher
Copy link
Collaborator

🚀 Preview deployed

Built with commit 08bd12e

https://deploy-preview-453--stoic-hodgkin-c0179e.netlify.com

@rc-publisher
Copy link
Collaborator

rc-publisher commented Nov 21, 2019 •
edited
Loading

🚀 Preview deployed

Built with commit e74839d

https://deploy-preview-453--stoic-hodgkin-c0179e.netlify.com

@HarisSpahijaPon
fix: remove template literals
4b0921b 
Signed-off-by: Haris Spahija <[email protected]>
aldeed
aldeed requested changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@aldeed aldeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still one eslint comma issue

@HarisSpahijaPon
fix: comma trailing
e74839d 
Signed-off-by: Haris Spahija <[email protected]>
@HarisSpahijaPon HarisSpahijaPon force-pushed the feat-harisspahijapon-add-overrides-checkoutactions branch from cc9e077 to e74839d Compare December 9, 2019 16:38
@spencern spencern merged commit eb7e504 into reactioncommerce:master Dec 9, 2019
@rc-publisher
Copy link
Collaborator

🎉 This PR is included in version 0.69.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rc-publisher rc-publisher added the released Applied automatically by semantic-release label Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldeed aldeed aldeed approved these changes

Assignees
No one assigned
Labels
released Applied automatically by semantic-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HarisSpahijaPon @rc-publisher @aldeed @spencern