-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added text overrides on StripePaymentCheckoutAction #461
feat: added text overrides on StripePaymentCheckoutAction #461
Conversation
Signed-off-by: Haris Spahija <[email protected]>
@aldeed these items should be translated aswell but are they part of the component? Should I add overrides in the same way? const billingAddressOptions = [{
id: "1",
label: "Same as shipping address",
value: "same_as_shipping"
},
{
id: "2",
label: "Use a different billing address",
value: "use_different_billing_address"
}]; |
@HarisSpahijaPon Yes, I would move it down into the component and add |
package/src/components/StripePaymentCheckoutAction/v1/StripePaymentCheckoutAction.js
Show resolved
Hide resolved
Signed-off-by: Haris Spahija <[email protected]>
🚀 Preview deployed Built with commit 1aef6f5 https://deploy-preview-461--stoic-hodgkin-c0179e.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to deal with billingAddressOptions
as discussed above
I currently have very little time to do this one, I opened it to the community in the story. Maybe someone can fix this for a new release. |
It works as is and |
🎉 This PR is included in version 0.69.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Signed-off-by: Haris Spahija [email protected]
Part of: #409
Impact: minor
Type: feature
Component
StripePaymentCheckoutAction now has overrides when i18next will be implemented (see #409)
Breaking changes
No breaking chances, all added fields are optional
Testing
billingAddressTitleText
to<StripePaymentCheckoutAction />
"test"
tobillingAddressTitleText
billingAddressTitleText
is not added, it should default to the values given in default propsAdded props: