Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring for v5.2 #273

Merged
merged 28 commits into from
Dec 19, 2024
Merged

Refactoring for v5.2 #273

merged 28 commits into from
Dec 19, 2024

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Dec 11, 2024 •
edited
Loading

Description

A lot of features have been added since reactpy-django was released. This PR implements any organization, renaming, and cleanup needed to make the source code feel more cohesive.

This PR has no changes to anything within the public API.

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@Archmonger
Use ensure_async instead of database_sync_to_async
cfde802
@Archmonger
Handle all pyright warnings
1070b80
@Archmonger
Add CI workflow for pyright
8ec20b7
@Archmonger
Grouo pyscript related code into module
3711803
@Archmonger
cached_static_contents -> cached_static_file
1ee2799
@Archmonger
vdom_or_component_to_string -> reactpy_to_string
e7d1764
@Archmonger
strtobool -> str_to_bool
67966e2
@Archmonger
Fix borked type hints
8ab7f23
@Archmonger
More generic function for form field conversion
5d2dd0e
@Archmonger
validate_form_args function
16f076d
@Archmonger
Refactor javascript
1a4fcaa
@Archmonger
rename clean module to tasks
90a6308
@Archmonger
Fix one instance of test flakiness
0b593a5
@Archmonger
Add test retries
0cd8218
@Archmonger
hatch fmt
1e1bf36
@Archmonger
rename hook async_render -> render_view
2a1fa06
@Archmonger
Turn navigate_to_page into a decorator
c8d6cf9
@Archmonger
Refactor PlaywrightTestCase
9f9f99d
@Archmonger
Move flaky marker to sync form test
c5f8d68
@Archmonger
Apparently I forgot PyScript FFI docs
fa13697
@Archmonger
Test performance optimization: Use same class for alll component tests
a607daa
@Archmonger
Fix typo
4165542
@Archmonger Archmonger linked an issue Dec 18, 2024 that may be closed by this pull request
Speed up tests by creating a dedicated PlaywrightFixture #261
Closed
@Archmonger Archmonger marked this pull request as ready for review December 19, 2024 09:51
@Archmonger Archmonger requested a review from a team as a code owner December 19, 2024 09:51
@Archmonger Archmonger merged commit 464b4e2 into reactive-python:main Dec 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speed up tests by creating a dedicated PlaywrightFixture
1 participant
@Archmonger